Skip to content

[Docs][V1] Optimize diagrams in prefix caching design #15716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2025
Merged

[Docs][V1] Optimize diagrams in prefix caching design #15716

merged 1 commit into from
Mar 29, 2025

Conversation

@simpx
Copy link
Contributor

@simpx simpx commented Mar 28, 2025 •
edited by github-actions bot
Loading

  • Update misleading block hash
  • Refine diagram annotations

the original drawio file: example-time.drawio.zip

(Should the .drawio file be added to the repository?)

@simpx
[Docs][V1] Optimize diagrams in prefix caching design
144d312 
- Update misleading block hash
- Refine diagram annotations

Signed-off-by: simpx <simpxx@gmail.com>
@github-actions
Copy link

github-actions bot commented Mar 28, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 28, 2025
comaniac
comaniac approved these changes Mar 29, 2025
View reviewed changes
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

@comaniac comaniac enabled auto-merge (squash) March 29, 2025 03:10
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 29, 2025
@comaniac comaniac merged commit cff8991 into vllm-project:main Mar 29, 2025
25 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@simpx @Alex4210987
[Docs][V1] Optimize diagrams in prefix caching design (vllm-project#1…
87d0452 
…5716)

Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@simpx @lulmer
[Docs][V1] Optimize diagrams in prefix caching design (vllm-project#1…
2857da3 
…5716)

Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@simpx @lk-chen
[Docs][V1] Optimize diagrams in prefix caching design (vllm-project#1…
e1cec65 
…5716)
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@simpx @shreyankg
[Docs][V1] Optimize diagrams in prefix caching design (vllm-project#1…
5bfa089 
…5716)
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@simpx
[Docs][V1] Optimize diagrams in prefix caching design (vllm-project#1…
6e29180 
…5716)

Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@comaniac comaniac comaniac approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simpx @comaniac