Skip to content

Conversation

@WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Mar 30, 2025

Currently, we call _try_schedule_encoder_inputs for every request and every step.
This PR avoids this function call by only calling it when the request includes encoder inputs (e.g., images).

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@WoosukKwon WoosukKwon changed the title [V1][Scheduler] Minor optimization for scheduler [V1][Scheduler] Avoid calling _try_schedule_encoder_inputs for every request Mar 30, 2025
@mergify mergify bot added the v1 label Mar 30, 2025
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 30, 2025
@WoosukKwon WoosukKwon merged commit 9b459ec into main Mar 30, 2025
35 of 44 checks passed
@WoosukKwon WoosukKwon deleted the minor-sched-opt branch March 30, 2025 21:10
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
…y request (vllm-project#15778)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
…y request (vllm-project#15778)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
…y request (vllm-project#15778)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
…y request (vllm-project#15778)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…y request (vllm-project#15778)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants