Skip to content

fix: can not use uv run collect_env close #13888 #15792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2025
Merged

fix: can not use uv run collect_env close #13888 #15792

merged 2 commits into from
Apr 1, 2025

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Mar 31, 2025 •
edited by github-actions bot
Loading

FIX #13888

This patch close #13888 by using uv pip when there's no pip in the
uv venv env.

For uv run there will be an env name UV so we can use it.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

Personally I think we should put the uv pip logic inside run_with_pip, what are your thoughts @youkaichao ?

@yihong0618
Copy link
Contributor Author

Personally I think we should put the uv pip logic inside run_with_pip, what are your thoughts @youkaichao ?

both OK for me, and maybe need to consider pdm

@yihong0618
Copy link
Contributor Author

put the uv pip logic inside run_with_pip

addressed

@DarkLight1337
Copy link
Member

Can you merge from main to fix the Docker build issue?

@yihong0618
fix: can not use uv run collect_env close vllm-project#13888
08f68b9 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618
fix: address comments put uv logic to run_with_pip
8d52a77 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618 yihong0618 force-pushed the hy/fix_can_not_use_uv_collect branch from aeb1b50 to 8d52a77 Compare April 1, 2025 06:55
@yihong0618
Copy link
Contributor Author

Can you merge from main to fix the Docker build issue?

merged and rebased

DarkLight1337
DarkLight1337 reviewed Apr 1, 2025
View reviewed changes
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 1, 2025 07:03
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 1, 2025
@DarkLight1337 DarkLight1337 merged commit 8af5a5c into vllm-project:main Apr 1, 2025
16 of 18 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@yihong0618 @Alex4210987
fix: can not use uv run collect_env close vllm-project#13888 (vllm-pr…
74c9a55 
…oject#15792)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@yihong0618 @lulmer
fix: can not use uv run collect_env close vllm-project#13888 (vllm-pr…
9d2e02b 
…oject#15792)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@yihong0618 @lk-chen
fix: can not use uv run collect_env close vllm-project#13888 (vllm-pr…
53f3479 
…oject#15792)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@yihong0618 @shreyankg
fix: can not use uv run collect_env close vllm-project#13888 (vllm-pr…
32edeb9 
…oject#15792)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@yihong0618
fix: can not use uv run collect_env close vllm-project#13888 (vllm-pr…
a4b3635 
…oject#15792)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@yankay yankay mentioned this pull request Sep 2, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: collect_env doesn't work in uv environment

2 participants

@yihong0618 @DarkLight1337