Skip to content

Conversation

@yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Mar 31, 2025

This patch fix requirements in setup.py has other things
e.g. comment and empty string

use cpu as example:

before this patch

      ['# Common dependencies', 'cachetools', 'psutil', 'sentencepiece  # Required for LLaMA tokenizer.', 'numpy', 'requests >= 2.26.0', 'tqdm', 'blake3',
      'py-cpuinfo', 'transformers >= 4.48.2  # Required for Bamba model and Transformers backend.', 'tokenizers >= 0.19.1  # Required for Llama 3.', 'protobuf #
      Required by LlamaTokenizer.', "fastapi[standard] >= 0.115.0 # Required by FastAPI's form models in the OpenAI API server's audio transcriptions endpoint.",
      'aiohttp', 'openai >= 1.52.0 # Ensure modern openai package (ensure types module present and max_completion_tokens field support)', 'pydantic >= 2.9',
      'prometheus_client >= 0.18.0', 'pillow  # Required for image processing', 'prometheus-fastapi-instrumentator >= 7.0.0', 'tiktoken >= 0.6.0  # Required
      for DBRX tokenizer', 'lm-format-enforcer >= 0.10.11, < 0.11', 'llguidance >= 0.7.9, < 0.8.0; platform_machine == "x86_64" or platform_machine == "arm64"
      or platform_machine == "aarch64"', 'outlines == 0.1.11', 'lark == 1.2.2', 'xgrammar == 0.1.16; platform_machine == "x86_64" or platform_machine ==
      "aarch64"', 'typing_extensions >= 4.10', 'filelock >= 3.16.1 # need to contain https://github.com/tox-dev/filelock/pull/317', 'partial-json-parser # used
      for parsing partial JSON outputs', 'pyzmq', 'msgspec', 'gguf == 0.10.0', 'importlib_metadata', 'mistral_common[opencv] >= 1.5.4', 'pyyaml', "six>=1.16.0;
      python_version > '3.11' # transitive dependency of pandas that needs to be the latest version for python 3.12", "setuptools>=74.1.1; python_version
      > '3.11' # Setuptools is used by triton, we need to ensure a modern version is installed for 3.12+ so that it does not try to import distutils, which
      was removed in 3.12", 'einops # Required for Qwen2-VL.', 'compressed-tensors == 0.9.2 # required for compressed-tensors', 'depyf==0.18.0 # required for
      profiling and debugging with compilation config', 'cloudpickle # allows pickling lambda functions in model_executor/models/registry.py', 'watchfiles #
      required for http server to monitor the updates of TLS files', 'python-json-logger # Used by logging as per examples/other/logging_configuration.md',
      'scipy # Required for phi-4-multimodal-instruct', 'ninja # Required for xgrammar, rocm, tpu, xpu', '', '# Dependencies for CPUs', 'torch==2.6.0+cpu;
      platform_machine == "x86_64"', 'torch==2.6.0; platform_system == "Darwin"', 'torch==2.6.0; platform_machine == "ppc64le" or platform_machine == "aarch64"',
      'torch==2.7.0.dev20250304; platform_machine == "s390x"', '', '# required for the image processor of minicpm-o-2_6, this must be updated alongside torch',
      'torchaudio; platform_machine != "ppc64le" and platform_machine != "s390x"', 'torchaudio==2.6.0; platform_machine == "ppc64le"', '', '# required for
      the image processor of phi3v, this must be updated alongside torch', 'torchvision; platform_machine != "ppc64le"  and platform_machine != "s390x"',
      'torchvision==0.21.0; platform_machine == "ppc64le"', 'datasets # for benchmark scripts']

with this patch

      ['cachetools', 'psutil', 'sentencepiece  # Required for LLaMA tokenizer.', 'numpy', 'requests >= 2.26.0', 'tqdm', 'blake3', 'py-cpuinfo', 'transformers >=
      4.48.2  # Required for Bamba model and Transformers backend.', 'tokenizers >= 0.19.1  # Required for Llama 3.', 'protobuf # Required by LlamaTokenizer.',
      "fastapi[standard] >= 0.115.0 # Required by FastAPI's form models in the OpenAI API server's audio transcriptions endpoint.", 'aiohttp', 'openai >=
      1.52.0 # Ensure modern openai package (ensure types module present and max_completion_tokens field support)', 'pydantic >= 2.9', 'prometheus_client >=
      0.18.0', 'pillow  # Required for image processing', 'prometheus-fastapi-instrumentator >= 7.0.0', 'tiktoken >= 0.6.0  # Required for DBRX tokenizer',
      'lm-format-enforcer >= 0.10.11, < 0.11', 'llguidance >= 0.7.9, < 0.8.0; platform_machine == "x86_64" or platform_machine == "arm64" or platform_machine ==
      "aarch64"', 'outlines == 0.1.11', 'lark == 1.2.2', 'xgrammar == 0.1.16; platform_machine == "x86_64" or platform_machine == "aarch64"', 'typing_extensions
      >= 4.10', 'filelock >= 3.16.1 # need to contain https://github.com/tox-dev/filelock/pull/317', 'partial-json-parser # used for parsing partial JSON
      outputs', 'pyzmq', 'msgspec', 'gguf == 0.10.0', 'importlib_metadata', 'mistral_common[opencv] >= 1.5.4', 'pyyaml', "six>=1.16.0; python_version > '3.11'
      # transitive dependency of pandas that needs to be the latest version for python 3.12", "setuptools>=74.1.1; python_version > '3.11' # Setuptools is
      used by triton, we need to ensure a modern version is installed for 3.12+ so that it does not try to import distutils, which was removed in 3.12",
      'einops # Required for Qwen2-VL.', 'compressed-tensors == 0.9.2 # required for compressed-tensors', 'depyf==0.18.0 # required for profiling and debugging
      with compilation config', 'cloudpickle # allows pickling lambda functions in model_executor/models/registry.py', 'watchfiles # required for http
      server to monitor the updates of TLS files', 'python-json-logger # Used by logging as per examples/other/logging_configuration.md', 'scipy # Required
      for phi-4-multimodal-instruct', 'ninja # Required for xgrammar, rocm, tpu, xpu',  'torch==2.6.0+cpu; platform_machine == "x86_64"',
      'torch==2.6.0; platform_system == "Darwin"', 'torch==2.6.0; platform_machine == "ppc64le" or platform_machine == "aarch64"', 'torch==2.7.0.dev20250304;
      platform_machine == "s390x"', 'torchaudio; platform_machine != "ppc64le" and platform_machine != "s390x"', 'torchaudio==2.6.0; platform_machine ==
      "ppc64le"', 'torchvision; platform_machine != "ppc64le"  and platform_machine != "s390x"', 'torchvision==0.21.0; platform_machine == "ppc64le"', 'datasets
      # for benchmark scripts']

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Mar 31, 2025
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 31, 2025 06:20
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 31, 2025
@vllm-bot vllm-bot merged commit e7ae3bf into vllm-project:main Mar 31, 2025
59 of 64 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
…#15796)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
…#15796)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…#15796)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants