Skip to content

fix: change GB to GiB in logging close #14979 #15807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2025
Merged

fix: change GB to GiB in logging close #14979 #15807

merged 3 commits into from
Mar 31, 2025

Conversation

@yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Mar 31, 2025 •
edited by github-actions bot
Loading

AS title

FIX #14979

@yihong0618
fix: change GB to GiB in logging close vllm-project#14979
8c7bb0d 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 31, 2025
@DarkLight1337
Copy link
Member

Can we also use vllm.utils.GiB_bytes where appropriate?

@yihong0618
fix: address comments
dff2303 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618
fix: import lint
bc77bab 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@DarkLight1337
Copy link
Member

Thanks for cleaning this up!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 31, 2025 13:57
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 31, 2025
@vllm-bot vllm-bot merged commit 2de4118 into vllm-project:main Mar 31, 2025
34 of 38 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@yihong0618 @Alex4210987
fix: change GB to GiB in logging close vllm-project#14979 (vllm-proje…
bfb05e6 
…ct#15807)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@yihong0618 @lulmer
fix: change GB to GiB in logging close vllm-project#14979 (vllm-proje…
cabe554 
…ct#15807)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@yihong0618 @lk-chen
fix: change GB to GiB in logging close vllm-project#14979 (vllm-proje…
d7fbfd2 
…ct#15807)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@yihong0618 @shreyankg
fix: change GB to GiB in logging close vllm-project#14979 (vllm-proje…
cac606a 
…ct#15807)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@yihong0618
fix: change GB to GiB in logging close vllm-project#14979 (vllm-proje…
5dfc8a5 
…ct#15807)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Model weights in GiB

3 participants

@yihong0618 @DarkLight1337 @vllm-bot