-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[Bugfix] Fix Crashing When Loading Modules With Batchnorm Stats #15813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix Crashing When Loading Modules With Batchnorm Stats #15813
Conversation
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks for fixing!
…-project#15813) Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com> Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
…-project#15813) Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
…-project#15813) Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
…-project#15813) Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
…-project#15813) Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Currently, the
AutoWeightsLoadercrashes if it encounters batch normalization stats in the model's safetensors. This is because the bn stats aren't part of thenamed_parameters, but they are part of the state dict, likely due to the reasons mentioned on the PyTorch forums here.This PR adds loading the bn stats for the the torch module
_BatchNorm's subclasses, as well as some tests that currently throw ValueErrors.(This fix is needed for the upcoming granite speech models from our group. Currently, there aren't many models in vLLM that use batchnorm except for phi4mm audio, which disables it by default, which is why it probably hasn't popped up before).
CC @njhill @tlrmchlsmth