Skip to content

[Bugfix] Check dimensions of multimodal embeddings in V1 #15816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 31, 2025
Merged

[Bugfix] Check dimensions of multimodal embeddings in V1 #15816

merged 15 commits into from
Mar 31, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Mar 31, 2025 •
edited by github-actions bot
Loading

Assert that get_multimodal_embeddings indeed outputs a sequence of 2-D tensors, and fix the models that fail the assertion.

During the process, I found that some example scripts cannot run on L40 without OOM so I updated them.

This is to facilitate #15712

@DarkLight1337
[V1] Avoid unnecessary dummy data creation
8b362a8 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Propagate mm_counts
dddaaad 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Fix
65878e0 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Loosen check
3810b7e 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Merge branch 'main' into override-mm-counts
8e8131e
@DarkLight1337
Avoid OOM during profiling
36c70df 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Validate multimodal embeddings
e013d0e 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Merge main
5dc0c32 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Fix onevision
0c943bd 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Fixes
2312f42 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Update
1da804e 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Update
019faa5 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Update examples
3d54883 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 31, 2025
@DarkLight1337 DarkLight1337 requested a review from mgoin March 31, 2025 12:22
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation v1 tpu Related to Google TPUs labels Mar 31, 2025
@DarkLight1337 DarkLight1337 self-assigned this Mar 31, 2025
@DarkLight1337 DarkLight1337 moved this to In Progress in Multi-modality Core Mar 31, 2025
@DarkLight1337 DarkLight1337 changed the title [V1] Check dimensions of multimodal embeddings [Bugfix] Check dimensions of multimodal embeddings in V1 Mar 31, 2025
NickLucche
NickLucche approved these changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@NickLucche NickLucche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

mgoin
mgoin approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one nit

@DarkLight1337
Fix
455c711 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@vllm-bot vllm-bot merged commit 09e974d into vllm-project:main Mar 31, 2025
3 of 6 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Multi-modality Core Mar 31, 2025
@DarkLight1337 DarkLight1337 deleted the validate-mm-embeddings branch March 31, 2025 16:01
@DarkLight1337 DarkLight1337 mentioned this pull request Mar 31, 2025
Merged
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@DarkLight1337 @Alex4210987
[Bugfix] Check dimensions of multimodal embeddings in V1 (vllm-projec…
3609cbb 
…t#15816)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@DarkLight1337 @lulmer
[Bugfix] Check dimensions of multimodal embeddings in V1 (vllm-projec…
f6c1a50 
…t#15816)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @lk-chen
[Bugfix] Check dimensions of multimodal embeddings in V1 (vllm-projec…
a24579c 
…t#15816)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@DarkLight1337 @shreyankg
[Bugfix] Check dimensions of multimodal embeddings in V1 (vllm-projec…
be6cbee 
…t#15816)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Bugfix] Check dimensions of multimodal embeddings in V1 (vllm-projec…
41d2d0d 
…t#15816)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@NickLucche NickLucche NickLucche approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@njhill njhill Awaiting requested review from njhill

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

Assignees

@DarkLight1337 DarkLight1337

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1

Projects

Multi-modality Core
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DarkLight1337 @mgoin @NickLucche @vllm-bot