Skip to content

Conversation

NickLucche
Copy link
Collaborator

@NickLucche NickLucche commented Apr 1, 2025

We're compiling a few extra graphs for sampling that we should never come across at runtime.
Namely the number of requests that require sampling can never exceed the number of tokens that are generated.
Eg. when we get N=16 tokens in input, we are not going to get 128 sequences for sampling. So only compile up to N.

Assuming max number of sequences = 32

INFO 04-01 11:04:44 [tpu_model_runner.py:839] Compiling sampling with different input shapes.
INFO 04-01 11:04:44 [tpu_model_runner.py:860]   -- num_tokens: 16, num_seqs: 8
INFO 04-01 11:04:44 [tpu_model_runner.py:860]   -- num_tokens: 16, num_seqs: 16<==
INFO 04-01 11:04:46 [tpu_model_runner.py:860]   -- num_tokens: 32, num_seqs: 8
INFO 04-01 11:04:47 [tpu_model_runner.py:860]   -- num_tokens: 32, num_seqs: 16
INFO 04-01 11:04:48 [tpu_model_runner.py:860]   -- num_tokens: 32, num_seqs: 32

Signed-off-by: NickLucche <nlucches@redhat.com>
Copy link

github-actions bot commented Apr 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added v1 tpu Related to Google TPUs labels Apr 1, 2025
Copy link
Collaborator

@yaochengji yaochengji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) April 2, 2025 16:37
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 2, 2025
@robertgshaw2-redhat robertgshaw2-redhat merged commit bd7599d into vllm-project:main Apr 3, 2025
41 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants