-
-
Couldn't load subscription status.
- Fork 10.9k
[Bugfix] Fix bug when dataset is json #15899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix bug when dataset is json #15899
Conversation
Signed-off-by: Chenyaaang <chenyangli@google.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
To better understand the fix, could you please provide a test case that demonstrates the bug you've addressed? |
|
I think it would be cleaner to just add another elif args.dataset == "json":
json_schemas = [schema]That way we don't have to modify |
|
Added in the description. |
How about Edit: actually it doesn't look like they need to be of the same length since we apply modulus operator before indexing the list of schemas. |
Signed-off-by: Chenyaaang <chenyangli@google.com>
Thanks, fixed. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bearing with me!
Signed-off-by: Chenyaaang <chenyangli@google.com>
Signed-off-by: Chenyaaang <chenyangli@google.com> Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Chenyaaang <chenyangli@google.com>
Signed-off-by: Chenyaaang <chenyangli@google.com>
Signed-off-by: Chenyaaang <chenyangli@google.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
In benchmark_serving_structured_output.py, when dataset is json, use the original loaded
schemainstead of creatingjson_schemas.The sample command provided in
benchmark_serving_structured_output.pydoesn't work because it fails atsample_requests()for json dataset.python benchmarks/benchmark_serving_structured_output.py
--backend
--model <your_model>
--dataset json
--structured-output-ratio 1.0
--structured-output-backend xgrammar
--request-rate 10
--num-prompts 1000