-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[V1] Fix: make sure k_index is int64 for apply_top_k_only
#15907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
WoosukKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @njhill An idea why this bug has not been detected in tests?
|
@njhill It's because the test uses
|
|
Thanks for fixing @b8zhong |
…roject#15907) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca> Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
…roject#15907) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
…roject#15907) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
…roject#15907) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
…roject#15907) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
The sampler in vLLM fails with
RuntimeError: gather(): Expected dtype int64 for indexbecause the index tensor for
torch.gatherisn’t cast totorch.int64, resulting in a dtype mismatch error. this cast should be safe.Bug reproduction
python benchmarks/benchmark_serving.py \ --backend deepspeed-mii \ --model NousResearch/Meta-Llama-3-8B-Instruct \ --host 127.0.0.1 \ --port 8000 \ --dataset-name random \ --num-prompts 100 \ --request-rate 10cc @houseroad I think you would probably know this. What do you think?