Skip to content

fix: better error message for get_config close #13889 #15943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2025
Merged

fix: better error message for get_config close #13889 #15943

merged 3 commits into from
Apr 3, 2025

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Apr 2, 2025 •
edited by github-actions bot
Loading

FIX #13889

for better error message to hint users

@yihong0618
fix: better error message for get_config close vllm-project#13889
301e92d 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@github-actions
Copy link

github-actions bot commented Apr 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

DarkLight1337
DarkLight1337 reviewed Apr 2, 2025
View reviewed changes
@yihong0618
fix: address comments
2a8bae4 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
DarkLight1337
DarkLight1337 approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, otherwise LGTM

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 3, 2025
@yihong0618
fix: nit lint
362a08d 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618
Copy link
Contributor Author

Minor nit, otherwise LGTM

Thanks

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 3, 2025 01:33
@DarkLight1337 DarkLight1337 merged commit 37bfee9 into vllm-project:main Apr 3, 2025
32 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@yihong0618 @Alex4210987
fix: better error message for get_config close vllm-project#13889 (vl…
9382ec4 
…lm-project#15943)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@yihong0618 @lulmer
fix: better error message for get_config close vllm-project#13889 (vl…
fc59723 
…lm-project#15943)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@yihong0618 @lk-chen
fix: better error message for get_config close vllm-project#13889 (vl…
e4c721a 
…lm-project#15943)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@yihong0618 @shreyankg
fix: better error message for get_config close vllm-project#13889 (vl…
c5a2faa 
…lm-project#15943)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@yihong0618
fix: better error message for get_config close vllm-project#13889 (vl…
7c77c8a 
…lm-project#15943)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: ValueError: Unsupported config format: ConfigFormat.AUTO on macOS

2 participants

@yihong0618 @DarkLight1337