Skip to content

Conversation

@robertgshaw2-redhat
Copy link
Collaborator

@robertgshaw2-redhat robertgshaw2-redhat commented Apr 2, 2025

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Apr 2, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay to revert for now to fix TPU build, fyi @hmellor

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like this change to be reinstated at some point, but if it unblocks TPU I'm happy to revert for now

@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) April 2, 2025 19:20
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 2, 2025
@gshtras
Copy link
Collaborator

gshtras commented Apr 2, 2025

I see a similar breakage on ROCm. hf-xet exists there, the issue seems to be related to how setuptools treats dependencies
In the def requires of the dist-packages/pkg_resources/init.py hf-xet is being renamed to hf_xet for some reason, and so there is a key exception

@gshtras
Copy link
Collaborator

gshtras commented Apr 2, 2025

Changing to
huggingface-hub[hf_xet] >= 0.30.0 # Required for Xet downloads.
seems to work

@hmellor
Copy link
Member

hmellor commented Apr 2, 2025

Thanks for the info @gshtras, I've made a PR #15969

@hmellor hmellor disabled auto-merge April 2, 2025 20:23
@mergify
Copy link

mergify bot commented Apr 2, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @robertgshaw2-redhat.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 2, 2025
@WoosukKwon
Copy link
Collaborator

Should we close this PR?

@mgoin
Copy link
Member

mgoin commented Apr 3, 2025

Superseded by #15969

@mgoin mgoin closed this Apr 3, 2025
@hmellor hmellor deleted the revert-15873-min-hf-hub-version branch April 3, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build needs-rebase ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants