-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Revert "Add minimum version for huggingface_hub to enable Xet downloads"
#15963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay to revert for now to fix TPU build, fyi @hmellor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like this change to be reinstated at some point, but if it unblocks TPU I'm happy to revert for now
|
I see a similar breakage on ROCm. hf-xet exists there, the issue seems to be related to how setuptools treats dependencies |
|
Changing to |
|
This pull request has merge conflicts that must be resolved before it can be |
|
Should we close this PR? |
|
Superseded by #15969 |
Reverts #15873
This broke some CI (https://buildkite.com/vllm/ci/builds/16810#0195f7c6-4c87-4e73-b81f-d779ea78487f)