Skip to content

[Bugfix] Fix default behavior/fallback for pp in v1 #16057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

[Bugfix] Fix default behavior/fallback for pp in v1 #16057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions vllm/engine/arg_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1521,8 +1521,9 @@ def _is_v1_supported_oracle(self, model_config: ModelConfig) -> bool:
# PP is supported on V1 with Ray distributed executor,
# but off for MP distributed executor for now.
if (self.pipeline_parallel_size > 1
and self.distributed_executor_backend == "mp"
and _warn_or_fallback("PP (MP distributed executor)")):
and self.distributed_executor_backend != "ray"):
name = "Pipeline Parallelism without Ray distributed executor"
_raise_or_fallback(feature_name=name, recommend_to_remove=False)
return False

# ngram is supported on V1, but off by default for now.
Expand Down