Skip to content

[Bugfix] Proper input validation for multi-modal encoder-decoder models #16156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 8, 2025
Merged

[Bugfix] Proper input validation for multi-modal encoder-decoder models #16156

merged 5 commits into from
Apr 8, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Apr 7, 2025 •
edited by github-actions bot
Loading

Test using

  • examples/offline_inference/encoder_decoder.py
  • examples/offline_inference/encoder_decoder_multimodal.py

@DarkLight1337
Try validate both encoder and decoder inputs
c3ba8bf 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 7, 2025
@DarkLight1337
Fix whisper
5d270bc 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@mergify mergify bot added documentation Improvements or additions to documentation multi-modality Related to multi-modality (#4194) labels Apr 8, 2025
@DarkLight1337 DarkLight1337 changed the title [WIP] Proper input validation for multi-modal encoder-decoder models [Bugfix] Proper input validation for multi-modal encoder-decoder models Apr 8, 2025
@DarkLight1337 DarkLight1337 marked this pull request as ready for review April 8, 2025 11:06
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 8, 2025
@DarkLight1337
Update comment
bdda71d 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
NickLucche
NickLucche approved these changes Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@NickLucche NickLucche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the whisper comments are super welcome to improve clarity. Thanks for the PR!

Isotr0py
Isotr0py approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!

@Isotr0py
Copy link
Member

Isotr0py commented Apr 8, 2025 •
edited
Loading

Seems that we should update the parameters for some encoder-decoder tests as well.

@DarkLight1337
Fix failing tests
bfd76b2 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 8, 2025 14:20
@DarkLight1337 DarkLight1337 requested a review from simon-mo as a code owner April 8, 2025 14:20
@vllm-bot vllm-bot merged commit 4ebc0b9 into vllm-project:main Apr 8, 2025
42 of 46 checks passed
@DarkLight1337 DarkLight1337 deleted the enc-dec-max-model-len branch April 8, 2025 16:45
@DarkLight1337 DarkLight1337 mentioned this pull request Apr 9, 2025
Closed
This was referenced Apr 10, 2025
Merged
Closed
@davidheineman davidheineman mentioned this pull request Apr 16, 2025
Merged
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@DarkLight1337 @yangw-dev
[Bugfix] Proper input validation for multi-modal encoder-decoder mode…
d484f67 
…ls (vllm-project#16156)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @dbyoung18
[Bugfix] Proper input validation for multi-modal encoder-decoder mode…
07c75c2 
…ls (vllm-project#16156)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @lk-chen
[Bugfix] Proper input validation for multi-modal encoder-decoder mode…
cebd2d5 
…ls (vllm-project#16156)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Bugfix] Proper input validation for multi-modal encoder-decoder mode…
6403371 
…ls (vllm-project#16156)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLucche NickLucche NickLucche approved these changes

@Isotr0py Isotr0py Isotr0py approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123

@youkaichao youkaichao Awaiting requested review from youkaichao

@heheda12345 heheda12345 Awaiting requested review from heheda12345

@simon-mo simon-mo Awaiting requested review from simon-mo simon-mo is a code owner

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DarkLight1337 @Isotr0py @NickLucche @vllm-bot