Skip to content

Conversation

@mlsw
Copy link
Contributor

@mlsw mlsw commented Apr 7, 2025

The current version of llm-compressor (0.5.0) is incompatible with vLLM. This is because it requires compressed-tensors==0.9.3, while vLLM is pinned to compressed-tensors==0.9.2. This PR updates the version of compressed-tensors pinned by vLLM.

Signed-off-by: Miles Williams <42222518+mlsw@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Apr 7, 2025
@markurtz
Copy link

markurtz commented Apr 7, 2025

Adding some additional info that this should be fine to allow since 0.9.2 and 0.9.3 do not have any high-level changes for compressed tensors—just some bug fixes and asym support for linear. Full diff between the versions here: vllm-project/compressed-tensors@0.9.2...0.9.3

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 7, 2025
@mgoin mgoin enabled auto-merge (squash) April 7, 2025 17:40
@mlsw
Copy link
Contributor Author

mlsw commented Apr 7, 2025

Thanks both! Regarding the CI failure, I think this unrelated?

@vllm-bot vllm-bot merged commit f94ab12 into vllm-project:main Apr 8, 2025
84 of 86 checks passed
@mlsw mlsw deleted the update-compressed-tensors branch April 10, 2025 22:34
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
Signed-off-by: Miles Williams <42222518+mlsw@users.noreply.github.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: Miles Williams <42222518+mlsw@users.noreply.github.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: Miles Williams <42222518+mlsw@users.noreply.github.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Miles Williams <42222518+mlsw@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants