Skip to content

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Apr 9, 2025

Adapting in updates to the triton fused_moe kernel to expand the supported quantization formats

This PR enables:

  • W8A8 FP8 for channel-wise weights and per-token activations
  • W8A8 INT8 for channel-wise weights and per-token activations
  • W8A8 INT8 for blocked weights and blocked per-token activation (like FP8 for DeepSeek)

Thank you to the sglang team for these developments pushing open source inference forward

Signed-off-by: mgoin <mgoin64@gmail.com>
@github-actions
Copy link

github-actions bot commented Apr 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin mgoin marked this pull request as ready for review April 10, 2025 00:54
@mgoin mgoin changed the title Support W8A8 channelwise in triton moe [Kernel] Support W8A8 channel-wise weights and per-token activations in triton fused_moe_kernel Apr 10, 2025
@bnellnm
Copy link
Collaborator

bnellnm commented Apr 10, 2025

There's a lot of commonality in the test files w/test_block_fp8.py. Would it be possible to move some of it to a common utility file?

mgoin added 2 commits April 11, 2025 00:13
Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin mgoin added performance Performance-related issues quantization moe ready ONLY add when PR is ready to merge/full CI is needed labels Apr 11, 2025
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) April 11, 2025 15:19
@robertgshaw2-redhat robertgshaw2-redhat merged commit f41647e into vllm-project:main Apr 11, 2025
66 checks passed
@mgoin mgoin deleted the triton-fused-moe-support-w8a8-ptpc branch April 12, 2025 16:13
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
…in triton fused_moe_kernel (vllm-project#16366)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
…in triton fused_moe_kernel (vllm-project#16366)

Signed-off-by: mgoin <mgoin64@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
…in triton fused_moe_kernel (vllm-project#16366)

Signed-off-by: mgoin <mgoin64@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…in triton fused_moe_kernel (vllm-project#16366)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

moe performance Performance-related issues quantization ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants