Skip to content

[Bugfix] Don't set an upper bound on repetition penalty #16403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2025
Merged

[Bugfix] Don't set an upper bound on repetition penalty #16403

merged 3 commits into from
Apr 11, 2025

Conversation

@alex-jw-brooks
Copy link
Contributor

@alex-jw-brooks alex-jw-brooks commented Apr 10, 2025 •
edited
Loading

This is a small fix to allow any non-negative values of repetition penalty to align with the transformers implementation (ref) instead of forcing (0, 2]! Not sure why this isn't allowed at the moment, maybe because of validation for allowed ranges for frequency/presence penalties based on openai docs being copied 🙂

@alex-jw-brooks
Don't set an upper bound on repetition penalty
f6a8022 
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
@github-actions
Copy link

github-actions bot commented Apr 10, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

njhill
njhill reviewed Apr 10, 2025
View reviewed changes
alex-jw-brooks and others added 2 commits April 10, 2025 17:25
@alex-jw-brooks @njhill
Update vllm/sampling_params.py
923920c 
Co-authored-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
@alex-jw-brooks
Make condition less ugly
5b142e6 
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
@alex-jw-brooks alex-jw-brooks force-pushed the allow_larger_rep_penality branch from bd81d8b to 5b142e6 Compare April 10, 2025 17:25
@alex-jw-brooks alex-jw-brooks requested a review from njhill April 10, 2025 17:30
njhill
njhill approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alex-jw-brooks

@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 10, 2025
@DarkLight1337 DarkLight1337 merged commit f8f9c0b into vllm-project:main Apr 11, 2025
57 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@alex-jw-brooks @njhill @yangw-dev
[Bugfix] Don't set an upper bound on repetition penalty (vllm-project…
8ee0e94 
…#16403)

Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Co-authored-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@alex-jw-brooks @njhill @dbyoung18
[Bugfix] Don't set an upper bound on repetition penalty (vllm-project…
2cb15ff 
…#16403)

Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Co-authored-by: Nick Hill <nhill@redhat.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@alex-jw-brooks @njhill @lk-chen
[Bugfix] Don't set an upper bound on repetition penalty (vllm-project…
61d86cb 
…#16403)

Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Co-authored-by: Nick Hill <nhill@redhat.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@alex-jw-brooks @njhill
[Bugfix] Don't set an upper bound on repetition penalty (vllm-project…
555b10c 
…#16403)

Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Co-authored-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njhill njhill njhill approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alex-jw-brooks @njhill @DarkLight1337