Skip to content

[TPU][V1] Use language_model interface for getting text backbone in MM #16410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

[TPU][V1] Use language_model interface for getting text backbone in MM #16410

merged 2 commits into from
Apr 10, 2025

Conversation

@NickLucche
Copy link
Collaborator

@NickLucche NickLucche commented Apr 10, 2025

Follow up on #15782.
Use the SupportsMultiModal.get_language_model method now that it is available.

@NickLucche
add language_model interface
880614a 
Signed-off-by: NickLucche <nlucches@redhat.com>
@github-actions
Copy link

github-actions bot commented Apr 10, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added v1 tpu Related to Google TPUs labels Apr 10, 2025
DarkLight1337
DarkLight1337 reviewed Apr 10, 2025
View reviewed changes
@NickLucche
Update vllm/v1/worker/tpu_model_runner.py
6b43f74 
Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>

Signed-off-by: NickLucche <nlucches@redhat.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 10, 2025 15:07
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 10, 2025
mgoin
mgoin approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DarkLight1337 DarkLight1337 merged commit c1b5785 into vllm-project:main Apr 10, 2025
44 of 46 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@NickLucche @yangw-dev
[TPU][V1] Use language_model interface for getting text backbone in…
dd5cc7e 
… MM (vllm-project#16410)

Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@NickLucche @dbyoung18
[TPU][V1] Use language_model interface for getting text backbone in…
372af95 
… MM (vllm-project#16410)

Signed-off-by: NickLucche <nlucches@redhat.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@NickLucche @lk-chen
[TPU][V1] Use language_model interface for getting text backbone in…
4ef49b1 
… MM (vllm-project#16410)

Signed-off-by: NickLucche <nlucches@redhat.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@NickLucche
[TPU][V1] Use language_model interface for getting text backbone in…
d29ca3f 
… MM (vllm-project#16410)

Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@njhill njhill Awaiting requested review from njhill

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NickLucche @mgoin @DarkLight1337