Skip to content

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Apr 10, 2025

Also cc @jeejeelee in case there is a bug at LoRA side.

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 10, 2025
Signed-off-by: Isotr0py <2037008807@qq.com>
@jeejeelee
Copy link
Collaborator

Thank you for the correction. The previous examples did indeed have issues.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 11, 2025 03:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 11, 2025
@DarkLight1337 DarkLight1337 merged commit 9319514 into vllm-project:main Apr 11, 2025
43 checks passed
@Isotr0py Isotr0py deleted the fix-phi4-mm branch April 11, 2025 05:21
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
…speech test (vllm-project#16424)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
…speech test (vllm-project#16424)

Signed-off-by: Isotr0py <2037008807@qq.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
…speech test (vllm-project#16424)

Signed-off-by: Isotr0py <2037008807@qq.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…speech test (vllm-project#16424)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants