Skip to content

[V1][Misc] stop update prefix cache stats when logs_stats is disabled #16460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2025
Merged

[V1][Misc] stop update prefix cache stats when logs_stats is disabled #16460

merged 3 commits into from
Apr 19, 2025

Conversation

@vie-serendipity
Copy link
Contributor

@vie-serendipity vie-serendipity commented Apr 11, 2025 •
edited by github-actions bot
Loading

When log stats are disabled, the prefix_cache_stats does not need to be initialized or updated.

vllm/vllm/v1/core/kv_cache_manager.py

Line 42 in 905e91e

# FIXME: make prefix cache stats conditional on log_stats

@vie-serendipity
feat: stop update prefix cache stats when logs_stats is disabled
3ba9d94 
Signed-off-by: vie-serendipity <2733147505@qq.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 11, 2025
@vie-serendipity
chore: ensure type safety
308bf88 
Signed-off-by: vie-serendipity <2733147505@qq.com>
comaniac
comaniac reviewed Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Could you add a simple unit test to metrics?

vllm/v1/core/kv_cache_manager.py

self.enable_caching = enable_caching
self.caching_hash_fn = sha256 if caching_hash_algo == "sha256" else hash
# FIXME: make prefix cache stats conditional on log_stats
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need this comment because when the log stats is enabled there are still potential configs we could expose in the future.

@comaniac comaniac added the needs-tests Tests needed for this PR label Apr 11, 2025
@vie-serendipity
Copy link
Contributor Author

Thanks for the PR. Could you add a simple unit test to metrics?

@comaniac Sure.

@vie-serendipity
test: add ut when log_stats is disabled
8a6a3f8 
Signed-off-by: vie-serendipity <2733147505@qq.com>
@vie-serendipity
Copy link
Contributor Author

@comaniac PTAL

@comaniac comaniac added ready ONLY add when PR is ready to merge/full CI is needed and removed needs-tests Tests needed for this PR labels Apr 15, 2025
@comaniac comaniac enabled auto-merge (squash) April 15, 2025 04:30
@vllm-bot vllm-bot merged commit d9737ca into vllm-project:main Apr 19, 2025
55 of 58 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@vie-serendipity @yangw-dev
[V1][Misc] stop update prefix cache stats when logs_stats is disabled (…
6dba95c 
…vllm-project#16460)

Signed-off-by: vie-serendipity <2733147505@qq.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@vie-serendipity @dbyoung18
[V1][Misc] stop update prefix cache stats when logs_stats is disabled (…
19eef85 
…vllm-project#16460)

Signed-off-by: vie-serendipity <2733147505@qq.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@vie-serendipity @lk-chen
[V1][Misc] stop update prefix cache stats when logs_stats is disabled (…
86842a8 
…vllm-project#16460)

Signed-off-by: vie-serendipity <2733147505@qq.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@vie-serendipity @adobrzyn
[V1][Misc] stop update prefix cache stats when logs_stats is disabled (…
1cb2763 
…vllm-project#16460)

Signed-off-by: vie-serendipity <2733147505@qq.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@vie-serendipity
[V1][Misc] stop update prefix cache stats when logs_stats is disabled (…
bc47450 
…vllm-project#16460)

Signed-off-by: vie-serendipity <2733147505@qq.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@comaniac comaniac comaniac approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vie-serendipity @comaniac @vllm-bot