-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[BugFix] Handle non-contiguous tensors properly when serializing #16492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nick Hill <nhill@redhat.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Nick Hill <nhill@redhat.com>
|
Thanks @comaniac! I realized the original PR was wrong though so have updated it and improved the test. |
…m-project#16492) Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: Yang Wang <elainewy@meta.com>
…m-project#16492) Signed-off-by: Nick Hill <nhill@redhat.com>
…m-project#16492) Signed-off-by: Nick Hill <nhill@redhat.com>
…m-project#16492) Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Follow-on to #13790. Both msgpack and zmq require contiguous tensors so ensure the tensor is converted in all cases.
Also use a msgpack ext for the inline case to avoid a copy on the decode side.