Skip to content

Conversation

@njhill
Copy link
Member

@njhill njhill commented Apr 11, 2025

Follow-on to #13790. Both msgpack and zmq require contiguous tensors so ensure the tensor is converted in all cases.

Also use a msgpack ext for the inline case to avoid a copy on the decode side.

Signed-off-by: Nick Hill <nhill@redhat.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@njhill njhill marked this pull request as draft April 11, 2025 15:37
Signed-off-by: Nick Hill <nhill@redhat.com>
@njhill njhill changed the title [Perf] Inline non-contiguous tensors when serializing [BugFix] Handle contiguous tensors properly when serializing Apr 11, 2025
@njhill njhill changed the title [BugFix] Handle contiguous tensors properly when serializing [BugFix] Handle non-contiguous tensors properly when serializing Apr 11, 2025
@njhill njhill added the bug Something isn't working label Apr 11, 2025
@njhill
Copy link
Member Author

njhill commented Apr 11, 2025

Thanks @comaniac! I realized the original PR was wrong though so have updated it and improved the test.

@njhill njhill marked this pull request as ready for review April 11, 2025 18:50
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 11, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 11, 2025 22:27
@vllm-bot vllm-bot merged commit 41cc883 into vllm-project:main Apr 12, 2025
59 of 61 checks passed
@njhill njhill deleted the contig-tensor-serial branch April 12, 2025 02:38
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
…m-project#16492)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…m-project#16492)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants