Skip to content

[V1][Structured Output] Move xgrammar related utils to backend_xgrammar.py #16578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

[V1][Structured Output] Move xgrammar related utils to backend_xgrammar.py #16578

merged 1 commit into from
Apr 16, 2025

Conversation

@shen-shanshan
Copy link
Contributor

@shen-shanshan shen-shanshan commented Apr 14, 2025 •
edited by github-actions bot
Loading

Move xgrammar related utils to backend_xgrammar.py, and only remain the common utils (backend unrelated) in vllm/v1/structured_output/utils.py.

This refactor is a part of #16171.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 14, 2025
@shen-shanshan shen-shanshan mentioned this pull request Apr 7, 2025
Closed
20 tasks
russellb
russellb approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@russellb russellb enabled auto-merge (squash) April 14, 2025 18:01
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 14, 2025
@DarkLight1337
Copy link
Member

Can you fix the failing test?

@shen-shanshan
Copy link
Contributor Author

Can you fix the failing test?

OK, no problem~

auto-merge was automatically disabled April 15, 2025 06:20

Head branch was pushed to by a user without write access

@shen-shanshan shen-shanshan force-pushed the v1-gd-1 branch 2 times, most recently from f9d0ddf to 94e2be2 Compare April 15, 2025 06:42
@shen-shanshan
Copy link
Contributor Author

shen-shanshan commented Apr 15, 2025 •
edited
Loading

Can you fix the failing test?

@DarkLight1337 I have updated the structured output CI test, but the other CI failures seem due to:

huggingface_hub.errors.HfHubHTTPError: 500 Server Error: Internal Server Error

@DarkLight1337
Copy link
Member

Let me retry them

@shen-shanshan shen-shanshan force-pushed the v1-gd-1 branch 2 times, most recently from 175b8ca to 7b0f16e Compare April 16, 2025 06:15
@shen-shanshan
move xgrammar related utils to backend_xgrammar.py
0105a80 
Signed-off-by: shen-shanshan <467638484@qq.com>
@shen-shanshan
Copy link
Contributor Author

Let me retry them

@DarkLight1337 CI is finally passed. 🥲

@DarkLight1337 DarkLight1337 merged commit 976711d into vllm-project:main Apr 16, 2025
43 checks passed
lionelvillard pushed a commit to lionelvillard/vllm that referenced this pull request Apr 17, 2025
@shen-shanshan @lionelvillard
[V1][Structured Output] Move xgrammar related utils to `backend_xgram…
77d5b30 
…mar.py` (vllm-project#16578)

Signed-off-by: shen-shanshan <467638484@qq.com>
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@shen-shanshan @yangw-dev
[V1][Structured Output] Move xgrammar related utils to `backend_xgram…
26912b8 
…mar.py` (vllm-project#16578)

Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@shen-shanshan @dbyoung18
[V1][Structured Output] Move xgrammar related utils to `backend_xgram…
1923282 
…mar.py` (vllm-project#16578)

Signed-off-by: shen-shanshan <467638484@qq.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@shen-shanshan @lk-chen
[V1][Structured Output] Move xgrammar related utils to `backend_xgram…
3355490 
…mar.py` (vllm-project#16578)

Signed-off-by: shen-shanshan <467638484@qq.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@shen-shanshan
[V1][Structured Output] Move xgrammar related utils to `backend_xgram…
1fe32db 
…mar.py` (vllm-project#16578)

Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russellb russellb russellb approved these changes

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@njhill njhill Awaiting requested review from njhill

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shen-shanshan @DarkLight1337 @russellb