Skip to content

[Bugfix] fix gpu docker image mis benchmarks dir #16628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

[Bugfix] fix gpu docker image mis benchmarks dir #16628

merged 1 commit into from
Apr 16, 2025

Conversation

@lengrongfu
Copy link
Contributor

@lengrongfu lengrongfu commented Apr 15, 2025 •
edited by github-actions bot
Loading

FIX #16602

@lengrongfu
[Bugfix] fix gpu docker image mis benchmarks dir
ac3a31c 
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
@lengrongfu lengrongfu marked this pull request as ready for review April 15, 2025 03:14
@mergify mergify bot added the ci/build label Apr 15, 2025
@lengrongfu
Copy link
Contributor Author

@hmellor please take a look.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor enabled auto-merge (squash) April 15, 2025 12:52
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 15, 2025
@vllm-bot vllm-bot merged commit 96bb8aa into vllm-project:main Apr 16, 2025
80 of 87 checks passed
lionelvillard pushed a commit to lionelvillard/vllm that referenced this pull request Apr 17, 2025
@lengrongfu @lionelvillard
[Bugfix] fix gpu docker image mis benchmarks dir (vllm-project#16628)
9d25ea4 
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@lengrongfu @yangw-dev
[Bugfix] fix gpu docker image mis benchmarks dir (vllm-project#16628)
46e5d7f 
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@lengrongfu @dbyoung18
[Bugfix] fix gpu docker image mis benchmarks dir (vllm-project#16628)
5a53c5a 
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@lengrongfu @lk-chen
[Bugfix] fix gpu docker image mis benchmarks dir (vllm-project#16628)
70bf924 
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@lengrongfu
[Bugfix] fix gpu docker image mis benchmarks dir (vllm-project#16628)
2b4a032 
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmellor hmellor hmellor approved these changes

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: vllm docker inage miss benchmarks dir

3 participants

@lengrongfu @hmellor @vllm-bot