Skip to content

[Bugfix] Fix broken GritLM model and tests (missing pooling_metadata) #16631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

[Bugfix] Fix broken GritLM model and tests (missing pooling_metadata) #16631

merged 2 commits into from
Apr 15, 2025

Conversation

@pooyadavoodi
Copy link
Contributor

@pooyadavoodi pooyadavoodi commented Apr 15, 2025 •
edited by github-actions bot
Loading

Pass pooling_metadata to pooler head in gritlm. This was broken by #16331.

#14516 broke gritlm tests due to switching attention backend from xformers to flash_attn.

@pooyadavoodi
Fix broken GritLM model and tests
2c06815 
Pass pooling_metadata to pooler head in gritlm. This was broken by PR vllm-project#16331 broke gritlm.

PR vllm-project#14516 broke gritlm tests
due to changing xformers to flash_atnn

Signed-off-by: Pooya Davoodi <pooya.davoodi@parasail.io>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

DarkLight1337
DarkLight1337 approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry we broke this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 15, 2025 04:11
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 15, 2025
@DarkLight1337
Copy link
Member

Can you fix pre-commit?

@pooyadavoodi
Fix pre-commit
bec5700 
Signed-off-by: Pooya Davoodi <pooya.davoodi@parasail.io>
auto-merge was automatically disabled April 15, 2025 04:21

Head branch was pushed to by a user without write access

@pooyadavoodi
Copy link
Contributor Author

Can you fix pre-commit?

Sorry I forgot that I am not on my regular dev machine that has pre-commit installed. Fixed now.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 15, 2025 04:33
@vllm-bot vllm-bot merged commit bc5dd4f into vllm-project:main Apr 15, 2025
39 of 46 checks passed
@noooop
Copy link
Collaborator

noooop commented Apr 15, 2025

Sorry for #16331 broken

yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@pooyadavoodi @yangw-dev
[Bugfix] Fix broken GritLM model and tests (missing pooling_metadata) (…
018dbb9 
…vllm-project#16631)

Signed-off-by: Pooya Davoodi <pooya.davoodi@parasail.io>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@pooyadavoodi @dbyoung18
[Bugfix] Fix broken GritLM model and tests (missing pooling_metadata) (…
46126aa 
…vllm-project#16631)

Signed-off-by: Pooya Davoodi <pooya.davoodi@parasail.io>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@pooyadavoodi @lk-chen
[Bugfix] Fix broken GritLM model and tests (missing pooling_metadata) (…
a90a994 
…vllm-project#16631)

Signed-off-by: Pooya Davoodi <pooya.davoodi@parasail.io>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@pooyadavoodi
[Bugfix] Fix broken GritLM model and tests (missing pooling_metadata) (…
de4fc26 
…vllm-project#16631)

Signed-off-by: Pooya Davoodi <pooya.davoodi@parasail.io>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pooyadavoodi @DarkLight1337 @noooop @vllm-bot