[Misc] refactor argument parsing in examples #16635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

DarkLight1337 merged 5 commits into vllm-project:main from reidliu41:refactor-examples-series-05

Apr 15, 2025

Contributor

reidliu41 commented Apr 15, 2025 •

edited by github-actions bot

Loading

Continue to refactor examples

extract parser to a func, make it cleaner
add some tips and refactor for gradio examples
refactor encoder_decoder


          [Misc] refactor examples

9e137f8

Signed-off-by: reidliu41 <reid201711@gmail.com>

github-actions bot commented Apr 15, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

mergify bot added the documentation label

DarkLight1337 changed the title ~~[Misc] refactor examples~~ [Misc] refactor argument parsing in examples

DarkLight1337 reviewed

View reviewed changes

examples/online_serving/gradio_openai_chatbot_webserver.py Outdated Show resolved Hide resolved

DarkLight1337 reviewed

View reviewed changes

examples/online_serving/gradio_openai_chatbot_webserver.py Outdated Show resolved Hide resolved

DarkLight1337 reviewed

View reviewed changes

examples/online_serving/gradio_openai_chatbot_webserver.py Outdated Show resolved Hide resolved

DarkLight1337 reviewed

View reviewed changes

examples/online_serving/gradio_webserver.py Outdated Show resolved Hide resolved


          remove the user

0e196ca

Signed-off-by: reidliu41 <reid201711@gmail.com>

DarkLight1337 reviewed

View reviewed changes

examples/online_serving/gradio_webserver.py Outdated Show resolved Hide resolved


          update with suggestion

9306e66

Signed-off-by: reidliu41 <reid201711@gmail.com>

DarkLight1337 reviewed

View reviewed changes

examples/online_serving/gradio_openai_chatbot_webserver.py Outdated Show resolved Hide resolved


          keep queue and launch in main

adb178f

Signed-off-by: reidliu41 <reid201711@gmail.com>

DarkLight1337 reviewed

View reviewed changes

examples/online_serving/gradio_openai_chatbot_webserver.py Outdated Show resolved Hide resolved


          remove host and port

67ad8e7

Signed-off-by: reidliu41 <reid201711@gmail.com>

DarkLight1337 approved these changes

View reviewed changes

Member

DarkLight1337 left a comment

LGTM now, thanks

DarkLight1337 enabled auto-merge (squash)

April 15, 2025 06:45

github-actions bot added the ready label

DarkLight1337 merged commit 6ae996a into vllm-project:main

27 of 29 checks passed

yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request


          [Misc] refactor argument parsing in examples (vllm-project#16635)

3aec79a

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Yang Wang <elainewy@meta.com>

jikunshang pushed a commit to jikunshang/vllm that referenced this pull request


          [Misc] refactor argument parsing in examples (vllm-project#16635)

30f1264

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>

lk-chen pushed a commit to lk-chen/vllm that referenced this pull request


          [Misc] refactor argument parsing in examples (vllm-project#16635)

dfd9b3a

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>

RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request


          [Misc] refactor argument parsing in examples (vllm-project#16635)

b6e2ee9

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>

ckhordiasma mentioned this pull request

nm vllm ent 0.8.5 sync red-hat-data-services/vllm#139

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation ready