Skip to content

Conversation

@luyuzhe111
Copy link
Contributor

@luyuzhe111 luyuzhe111 commented Apr 15, 2025

Currently, we try to automatically detect the speculative decoding method. For EAGLE, it detects via the draft model checkpoint folder. However, if the folder name does not have the eagle- substring, the current logic will make the method draft_model even if one has directly specify the method as eagle, which leads to subsequent errors. This fix avoids this confusion.

@LiuXiaoxuanPKU

Signed-off-by: Bryan Lu <yuzhelu@amazon.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Collaborator

@LiuXiaoxuanPKU LiuXiaoxuanPKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LiuXiaoxuanPKU LiuXiaoxuanPKU enabled auto-merge (squash) April 16, 2025 19:12
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 16, 2025
@vllm-bot vllm-bot merged commit 2cbd4d2 into vllm-project:main Apr 17, 2025
56 of 60 checks passed
lionelvillard pushed a commit to lionelvillard/vllm that referenced this pull request Apr 17, 2025
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
…oject#16636)

Signed-off-by: Bryan Lu <yuzhelu@amazon.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
…oject#16636)

Signed-off-by: Bryan Lu <yuzhelu@amazon.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…oject#16636)

Signed-off-by: Bryan Lu <yuzhelu@amazon.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants