Skip to content

Conversation

@SageMoore
Copy link
Contributor

See above. This should fix the baremetal rocm build. Another package is pulling in triton version 3.3 which doesn't match with the version that torch comes with (3.2). This is causing various exceptions to be thrown.

Signed-off-by: Sage Moore <sage@neuralmagic.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Apr 15, 2025
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which package is pulling in triton 3.3?

@SageMoore
Copy link
Contributor Author

Looks like xgrammar

(.venv) sage:~/git/vllm> pip show triton
Name: triton
Version: 3.3.0
...
Requires: setuptools
Required-by: xgrammar

I suspect it is just pulling in the triton package without specifying the version. I tried this on an nvidia system and I think we dodge the issue because torch explicitly depends on the triton package instead of bundling it

(.venv) sage@beaker ~/g/nm-vllm (main)> pip list | grep triton
triton                                   3.2.0
(.venv) sage@beaker ~/g/nm-vllm (main)> pip show triton
Name: triton
Version: 3.2.0
Summary: A language and compiler for custom Deep Learning operations
Home-page: https://github.com/triton-lang/triton/
Author: Philippe Tillet
Author-email: phil@openai.com
License:
Location: /home/sage/git/nm-vllm/.venv/lib/python3.10/site-packages
Requires:
Required-by: torch, xgrammar

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 15, 2025
@DarkLight1337 DarkLight1337 merged commit 44fa4d5 into vllm-project:main Apr 16, 2025
41 checks passed
@SageMoore SageMoore deleted the sage/minor-build-fixes branch April 16, 2025 16:21
lionelvillard pushed a commit to lionelvillard/vllm that referenced this pull request Apr 17, 2025
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
…ject#16664)

Signed-off-by: Sage Moore <sage@neuralmagic.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…ject#16664)

Signed-off-by: Sage Moore <sage@neuralmagic.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants