Skip to content

[Doc] Improve help examples for --compilation-config #16729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

[Doc] Improve help examples for --compilation-config #16729

merged 1 commit into from
Apr 18, 2025

Conversation

@DarkLight1337
Copy link
Member

Further improve documentation to address #16551 (comment)

@DarkLight1337
[Doc] Improve help examples for --compilation-config
142a3f2 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 16, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 16, 2025
jeejeelee
jeejeelee reviewed Apr 16, 2025
View reviewed changes
jeejeelee
jeejeelee reviewed Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can first consider integrating it in.

@vllm-bot vllm-bot merged commit c16fb5d into vllm-project:main Apr 18, 2025
46 of 48 checks passed
@DarkLight1337 DarkLight1337 deleted the torch-compile-arg-help branch April 18, 2025 04:22
@DarkLight1337 DarkLight1337 mentioned this pull request Apr 21, 2025
Merged
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@DarkLight1337 @yangw-dev
[Doc] Improve help examples for --compilation-config (vllm-project#…
dbd8973 
…16729)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @dbyoung18
[Doc] Improve help examples for --compilation-config (vllm-project#…
50298ec 
…16729)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @lk-chen
[Doc] Improve help examples for --compilation-config (vllm-project#…
3b22e76 
…16729)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@DarkLight1337 @adobrzyn
[Doc] Improve help examples for --compilation-config (vllm-project#…
ff2bcb1 
…16729)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Doc] Improve help examples for --compilation-config (vllm-project#…
9891f54 
…16729)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@hmellor hmellor Awaiting requested review from hmellor

@youkaichao youkaichao Awaiting requested review from youkaichao

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DarkLight1337 @jeejeelee @youkaichao @vllm-bot