-
-
Couldn't load subscription status.
- Fork 10.8k
[Bugfix] Update Florence-2 tokenizer to make grounding tasks work #16734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <2037008807@qq.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
…lm-project#16734) Signed-off-by: Isotr0py <2037008807@qq.com>
…lm-project#16734) Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Yang Wang <elainewy@meta.com>
|
@Isotr0py hey, its me again :). We are trying to validate the tasks here, but the model doesnt seem to be ok in some tasks. Tasks in which the response seems fine :CAPTION, DETAILED_CAPTION, MORE_DETAILED_CAPTION, There are some tasks that most of the times return empty content and rarely responds (usually with wrong stuff, as in the examples below): REGION_PROPOSAL , REGION_TO_CATEGORY and OD
For REGION_PROPOSAL: For OD : For REGION_TO_CATEGORY : This is what we are using: An example of request: @Isotr0py could you take a look in this? |
|
@PedroMiolaSilva Hmmm, I tried the below prompts and the outputs look reasonable to me: Outputs: Corresponding HF outputs: Anyway, let me test on your image as well... |
|
Hmm, seems that offline inference can also generate reasonable outputs on Perhaps the issue is about online serving? |
|
@PedroMiolaSilva You can try this: Seems that the first Outputs: |
…lm-project#16734) Signed-off-by: Isotr0py <2037008807@qq.com>
…lm-project#16734) Signed-off-by: Isotr0py <2037008807@qq.com>
…lm-project#16734) Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
|
@Isotr0py it worked here. Thanks again! |
…lm-project#16734) Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
FIX #16164 (comment)