Skip to content

[Bugfix] Fix the issue where llm.generate cannot be called repeatedly after setting GuidedDecodingParams #16767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2025
Merged

[Bugfix] Fix the issue where llm.generate cannot be called repeatedly after setting GuidedDecodingParams #16767

merged 3 commits into from
Apr 22, 2025

Conversation

@chaunceyjiang
Copy link
Collaborator

@chaunceyjiang chaunceyjiang commented Apr 17, 2025 •
edited by github-actions bot
Loading

FIX #16738

Fix the issue where llm.generate cannot be called repeatedly after setting GuidedDecodingParams

@chaunceyjiang
[Bugfix] Fix the issue where cannot be called repeatedly after setting .
4b40365 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@mergify mergify bot added the v1 label Apr 17, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@chaunceyjiang
Copy link
Collaborator Author

/cc @DarkLight1337 @russellb PTAL.

@russellb
Copy link
Member

Thanks for the PR! I'm taking a closer look now.

@dgslqh
Copy link

dgslqh commented Apr 17, 2025

I meet the same problem, thanks a lot!

@russellb
Remember when struct output backend was set via auto
b68fd90 
Closes vllm-project#16738

Signed-off-by: Russell Bryant <rbryant@redhat.com>
@russellb
Copy link
Member

@chaunceyjiang can you take a look at the commit I added? It's an alternate solution that I prefer, but want to make sure you're OK with it.

@chaunceyjiang
Copy link
Collaborator Author

@chaunceyjiang can you take a look at the commit I added? It's an alternate solution that I prefer, but want to make sure you're OK with it.

I think your solution is even better. @russellb

@russellb
Copy link
Member

Thanks for taking a look! Since I made changes, I asked for someone else to take a look for approval.

mgoin
mgoin approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I would like to see a test case specifically for this

@russellb
Copy link
Member

LGTM, however I would like to see a test case specifically for this

good point - I can do that pretty quick I think

@russellb
Add test for re-use of sampling_params with the auto backend
a05ba5c 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
@russellb russellb self-requested a review as a code owner April 17, 2025 15:30
@russellb
Copy link
Member

LGTM, however I would like to see a test case specifically for this

good point - I can do that pretty quick I think

added test coverage by slightly extending an existing test.

@chaunceyjiang
Copy link
Collaborator Author

/cc @russellb @DarkLight1337 I think this PR can be merged.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 22, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 22, 2025 06:02
@DarkLight1337 DarkLight1337 merged commit acba33a into vllm-project:main Apr 22, 2025
60 checks passed
@chaunceyjiang chaunceyjiang deleted the guided_decoding branch April 22, 2025 13:48
frieda-huang pushed a commit to frieda-huang/vllm that referenced this pull request Apr 23, 2025
@chaunceyjiang @russellb @frieda-huang
[Bugfix] Fix the issue where llm.generate cannot be called repeatedly…
7bc8c52 
… after setting GuidedDecodingParams (vllm-project#16767)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Frieda (Jingying) Huang <jingyingfhuang@gmail.com>
@kaimatzu
Copy link

When is this getting released?

@DarkLight1337
Copy link
Member

The next release will be around the end of this month. If you can't wait, you can install the nightly vLLM package.

https://docs.vllm.ai/en/latest/getting_started/installation/gpu.html#pre-built-wheels

@jgoriasilva
Copy link

Thanks! I was having the same problem and this solves it, I tested it with the nightly package.

jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@chaunceyjiang @russellb @dbyoung18
[Bugfix] Fix the issue where llm.generate cannot be called repeatedly…
aed04ad 
… after setting GuidedDecodingParams (vllm-project#16767)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Russell Bryant <rbryant@redhat.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@chaunceyjiang @russellb @lk-chen
[Bugfix] Fix the issue where llm.generate cannot be called repeatedly…
7934779 
… after setting GuidedDecodingParams (vllm-project#16767)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Russell Bryant <rbryant@redhat.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@chaunceyjiang @russellb @adobrzyn
[Bugfix] Fix the issue where llm.generate cannot be called repeatedly…
644f5cf 
… after setting GuidedDecodingParams (vllm-project#16767)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@chaunceyjiang @russellb
[Bugfix] Fix the issue where llm.generate cannot be called repeatedly…
12ab34c 
… after setting GuidedDecodingParams (vllm-project#16767)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@njhill njhill Awaiting requested review from njhill

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

@russellb russellb Awaiting requested review from russellb russellb is a code owner

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: GuidedDecodingParams choice - Request-level structured output backend must match engine-level backend

7 participants

@chaunceyjiang @russellb @dgslqh @kaimatzu @DarkLight1337 @jgoriasilva @mgoin