Skip to content

[Bugfix]Fix index out of range error in api server log #16787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

[Bugfix]Fix index out of range error in api server log #16787

merged 1 commit into from
Apr 17, 2025

Conversation

@WangErXiao
Copy link
Contributor

@WangErXiao WangErXiao commented Apr 17, 2025 •
edited by github-actions bot
Loading

Fix index out of range error in api server log.
When using VLLM_DEBUG_LOG_API_SERVER_RESPONSE and curl /health api , it throw error:
vllm/entrypoints/openai/api_server.py", line 884, in log_response
logger.info("response_body={%s}", response_body[0].decode())
IndexError: list index out of range.

@WangErXiao
[Bugfix]Fix index out of range error
32db68a 
Signed-off-by: WangErXiao <863579016@qq.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Apr 17, 2025
@WangErXiao
Copy link
Contributor Author

cc @terrytangyuan

DarkLight1337
DarkLight1337 approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 17, 2025 13:36
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 17, 2025
terrytangyuan
terrytangyuan approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vllm-bot vllm-bot merged commit 6211b92 into vllm-project:main Apr 17, 2025
47 of 51 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@WangErXiao @yangw-dev
[Bugfix]Fix index out of range error in api server log (vllm-project#…
849bec0 
…16787)

Signed-off-by: WangErXiao <863579016@qq.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@WangErXiao @dbyoung18
[Bugfix]Fix index out of range error in api server log (vllm-project#…
b44422a 
…16787)

Signed-off-by: WangErXiao <863579016@qq.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@WangErXiao @lk-chen
[Bugfix]Fix index out of range error in api server log (vllm-project#…
00ab6d1 
…16787)

Signed-off-by: WangErXiao <863579016@qq.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@WangErXiao @adobrzyn
[Bugfix]Fix index out of range error in api server log (vllm-project#…
7d466b7 
…16787)

Signed-off-by: WangErXiao <863579016@qq.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@WangErXiao
[Bugfix]Fix index out of range error in api server log (vllm-project#…
2766872 
…16787)

Signed-off-by: WangErXiao <863579016@qq.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

+1 more reviewer

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WangErXiao @terrytangyuan @DarkLight1337 @vllm-bot