Skip to content

Conversation

@jmho
Copy link
Contributor

@jmho jmho commented Apr 18, 2025

The current tool calling docs for the Llama models notes that only the Llama 3.1 models are supported for JSON based tool calling even though there is support for the Llama 3.2 models as well.

This PR removes a mention of a chat template that no longer exists, adds the llama 3.2 models under supported models, and provides additional info about the differences between the 3.1 and 3.2 json chat templates.

Signed-off-by: jmho <jaylenho734@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 18, 2025
Signed-off-by: jmho <jaylenho734@gmail.com>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 18, 2025 22:33
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 18, 2025
@DarkLight1337 DarkLight1337 merged commit 490b169 into vllm-project:main Apr 18, 2025
40 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
…nfig info (vllm-project#16857)

Signed-off-by: jmho <jaylenho734@gmail.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
…nfig info (vllm-project#16857)

Signed-off-by: jmho <jaylenho734@gmail.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…nfig info (vllm-project#16857)

Signed-off-by: jmho <jaylenho734@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants