Skip to content

[frontend] enhance tool_calls type check #16882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

[frontend] enhance tool_calls type check #16882

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef9a0c6
[frontend] enhance tool_calls type check
reidliu41 Apr 20, 2025
64d8493
update the condition
reidliu41 Apr 22, 2025
558df35
update a comment
reidliu41 Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion vllm/entrypoints/chat_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,11 @@ def _parse_chat_message_content(
if role == 'assistant':
parsed_msg = _AssistantParser(message)

if "tool_calls" in parsed_msg:
# The 'tool_calls' is not None check ensures compatibility.
# It's needed only if downstream code doesn't strictly
# follow the OpenAI spec.
if ("tool_calls" in parsed_msg
and parsed_msg["tool_calls"] is not None):
result_msg["tool_calls"] = list(parsed_msg["tool_calls"])
elif role == "tool":
parsed_msg = _ToolParser(message)
Expand Down