-
-
Couldn't load subscription status.
- Fork 10.8k
[Bugfix] Fix distributed bug in Qwen2.5-VL & Qwen2.5-Omni #16907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
Hi @DarkLight1337 @ywang96 , I'm sorry I didn't fix this bug in the last PR, please check. |
64b7be9 to
2825f4f
Compare
|
Thanks for fixing! |
…ct#16907) Signed-off-by: Yang Wang <elainewy@meta.com>
…ct#16907) Signed-off-by: Frieda (Jingying) Huang <jingyingfhuang@gmail.com>
…ct#16907) Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
…ct#16907) Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
This PR fixes the distribution bug in Qwen2.5-VL & Qwen2.5-Omni (introduced in #15130).
When
tp_group != world_size, current implementation will cause an allgather error.