Skip to content

Conversation

@fyabc
Copy link
Contributor

@fyabc fyabc commented Apr 21, 2025

This PR fixes the distribution bug in Qwen2.5-VL & Qwen2.5-Omni (introduced in #15130).

When tp_group != world_size, current implementation will cause an allgather error.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@fyabc
Copy link
Contributor Author

fyabc commented Apr 21, 2025

Hi @DarkLight1337 @ywang96 , I'm sorry I didn't fix this bug in the last PR, please check.

@fyabc fyabc force-pushed the qwen2_omni_public_v1 branch from 64b7be9 to 2825f4f Compare April 21, 2025 07:43
@DarkLight1337
Copy link
Member

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 21, 2025 08:07
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 21, 2025
@DarkLight1337 DarkLight1337 merged commit 26c0406 into vllm-project:main Apr 21, 2025
55 of 58 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
frieda-huang pushed a commit to frieda-huang/vllm that referenced this pull request Apr 23, 2025
…ct#16907)

Signed-off-by: Frieda (Jingying) Huang <jingyingfhuang@gmail.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
…ct#16907)

Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants