Skip to content

chore: use recommended Python install commands #16927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: use recommended Python install commands #16927

wants to merge 1 commit into from

Conversation

@davidxia
Copy link
Contributor

@davidxia davidxia commented Apr 21, 2025 •
edited by github-actions bot
Loading

PyPA deprecated python setup.py install and python setup.py develop and recommends pip install . and pip install --editable ., respectively.

@davidxia
chore: use recommended Python install commands
06218c0 
[PyPA deprecated][1] `python setup.py install` and `python setup.py develop`
and recommends `pip install .` and `pip install --editable .`, respectively.

[1]: https://packaging.python.org/en/latest/guides/modernize-setup-py-project/#should-setup-py-be-deleted

Signed-off-by: David Xia <david@davidxia.com>
@github-actions
Copy link

github-actions bot commented Apr 21, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Apr 21, 2025
@davidxia davidxia marked this pull request as ready for review April 21, 2025 15:44
@davidxia
Copy link
Contributor Author

davidxia commented Apr 21, 2025

This project uses setup.py because #16923 (comment)

@davidxia davidxia closed this Apr 21, 2025
@davidxia davidxia deleted the patch2 branch April 21, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci/build documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@davidxia