Skip to content

[BugFix] Remove default multiproc executor collective_rpc timeout #17000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

[BugFix] Remove default multiproc executor collective_rpc timeout #17000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions vllm/v1/executor/multiproc_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
POLLING_TIMEOUT_MS = 5000
POLLING_TIMEOUT_S = POLLING_TIMEOUT_MS // 1000

EXECUTE_MODEL_TIMEOUT_S = 30
EXECUTE_MODEL_TIMEOUT_S = 40


class MultiprocExecutor(Executor):
Expand Down Expand Up @@ -151,16 +151,16 @@ def execute_model(

def collective_rpc(self,
method: Union[str, Callable],
timeout: Optional[float] = 180.0,
timeout: Optional[float] = None,
args: tuple = (),
kwargs: Optional[dict] = None,
rank0_reply_only: bool = False) -> list[Any]:
start_time = time.monotonic()
kwargs = kwargs or {}

if self.is_failed:
raise RuntimeError("Executor failed.")

deadline = None if timeout is None else time.monotonic() + timeout
kwargs = kwargs or {}

# NOTE: If the args are heterogeneous, then we pack them into a list,
# and unpack them in the method of every worker, because every worker
# knows their own rank.
Expand All @@ -176,8 +176,8 @@ def collective_rpc(self,
workers = (self.workers[0], ) if rank0_reply_only else self.workers
responses = [None] * len(workers)
for w in workers:
dequeue_timeout = timeout - (time.monotonic() - start_time
) if timeout is not None else None
dequeue_timeout = None if deadline is None else (
deadline - time.monotonic())
status, result = w.worker_response_mq.dequeue(
timeout=dequeue_timeout, cancel=self.shutdown_event)

Expand Down