- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10.9k
Simplify (and fix) passing of guided decoding backend options #17008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            russellb
  merged 26 commits into
  vllm-project:main
from
hmellor:split-guided-decoding-backend-options
  
      
      
   
  Apr 29, 2025 
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            26 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      360026f
              
                Split `guided_decoding_backend` into `guided_decoding_backend` and `g…
              
              
                hmellor 0390b6f
              
                Typo
              
              
                hmellor dc9f57b
              
                Merge branch 'main' into split-guided-decoding-backend-options
              
              
                hmellor 49b89e5
              
                Merge branch 'main' into split-guided-decoding-backend-options
              
              
                hmellor 8a1ed06
              
                Merge branch 'main' into split-guided-decoding-backend-options
              
              
                hmellor 7a660b0
              
                Merge branch 'main' into split-guided-decoding-backend-options
              
              
                hmellor 592ff3d
              
                Fix typo
              
              
                hmellor 2979c31
              
                Use bool flags instead of cramming many flags into a dict
              
              
                hmellor 8a367ba
              
                Fix word order in args
              
              
                hmellor b9d4074
              
                Fix missing arg
              
              
                hmellor 0884458
              
                Enforce disable additional properties only works for guidance
              
              
                hmellor 4ebe137
              
                Missed the EngineArgs field
              
              
                hmellor 05ab20b
              
                Add backward compatible deprecated `guided_decoding_backend`
              
              
                hmellor a34a434
              
                Fix incorrect attribute in xgrammar
              
              
                hmellor ae2f1c3
              
                Fix test parameters
              
              
                hmellor 666ba39
              
                Merge `Literal`s with `Literal` not `Union`
              
              
                hmellor 6df5dbb
              
                Enforce that `Literal`s are merged with `Literal` not `Union`
              
              
                hmellor 08d5e20
              
                Add tests for `config` decorator
              
              
                hmellor 92300b6
              
                Create new helper function to handle sequences of literals
              
              
                hmellor 88c1479
              
                Add test for literal to kwarg
              
              
                hmellor 4037013
              
                Add test cases for `list[Literal]` and `Literal[Literal, Literal]`
              
              
                hmellor 0ecf76e
              
                Fix pre-commit
              
              
                hmellor 8beb8df
              
                Respond to comment
              
              
                hmellor e44135c
              
                Merge branch 'main' into split-guided-decoding-backend-options
              
              
                hmellor 008b037
              
                Merge branch 'config-literal-handling' into split-guided-decoding-bac…
              
              
                hmellor 39557d7
              
                Merge branch 'main' into split-guided-decoding-backend-options
              
              
                hmellor File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              Large diffs are not rendered by default.
      
      Oops, something went wrong.
      
    
  
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.