Skip to content

[ROCm][Misc] Follow-ups for Skinny Gemms on ROCm. #17011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 26, 2025
Merged

[ROCm][Misc] Follow-ups for Skinny Gemms on ROCm. #17011

merged 9 commits into from
Apr 26, 2025

Conversation

@charlifu
Copy link
Contributor

@charlifu charlifu commented Apr 22, 2025 •
edited by github-actions bot
Loading

  • Add skinny gemms path to vocab_parallel_embeddings
  • fix out_dtype for fp8 linear.
  • disable skinny gemms on navi

charlifu added 2 commits April 22, 2025 21:51
@charlifu
add skinny gemm path to embdding method
26f2d46 
Signed-off-by: charlifu <charlifu@amd.com>
@charlifu
use correct out dtype for fp8 linear
58975cb 
Signed-off-by: charlifu <charlifu@amd.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

charlifu and others added 5 commits April 23, 2025 15:44
@charlifu
disable skinny gemms on navi
ecbaed9 
Signed-off-by: charlifu <charlifu@amd.com>
@charlifu
disable fp8 skinny gemms for navi
1beb26a 
Signed-off-by: charlifu <charlifu@amd.com>
@charlifu
remove navi
be263e0 
Signed-off-by: charlifu <charlifu@amd.com>
@charlifu
Merge branch 'main' into charlifu/use_skinny_gemm_for_vocab
705c12a
@charlifu
Update utils.py
7d80a9f 
Signed-off-by: charlifu <charlifu@amd.com>
@charlifu charlifu force-pushed the charlifu/use_skinny_gemm_for_vocab branch from 39c51b7 to 7d80a9f Compare April 23, 2025 20:58
@hongxiayang hongxiayang added the rocm Related to AMD ROCm label Apr 24, 2025
DarkLight1337
DarkLight1337 approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp

@vllm-bot vllm-bot merged commit 54271bb into vllm-project:main Apr 26, 2025
21 checks passed
@charlifu charlifu deleted the charlifu/use_skinny_gemm_for_vocab branch April 26, 2025 16:12
@gshtras gshtras mentioned this pull request Apr 28, 2025
Closed
1 task
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@charlifu @dbyoung18
[ROCm][Misc] Follow-ups for Skinny Gemms on ROCm. (vllm-project#17011)
9cd7b26 
Signed-off-by: charlifu <charlifu@amd.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@charlifu @lk-chen
[ROCm][Misc] Follow-ups for Skinny Gemms on ROCm. (vllm-project#17011)
ec7ab1a 
Signed-off-by: charlifu <charlifu@amd.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@charlifu @adobrzyn
[ROCm][Misc] Follow-ups for Skinny Gemms on ROCm. (vllm-project#17011)
5c3c7fd 
Signed-off-by: charlifu <charlifu@amd.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@charlifu
[ROCm][Misc] Follow-ups for Skinny Gemms on ROCm. (vllm-project#17011)
b731187 
Signed-off-by: charlifu <charlifu@amd.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@charlifu
[ROCm][Misc] Follow-ups for Skinny Gemms on ROCm. (vllm-project#17011)
17eaf93 
Signed-off-by: charlifu <charlifu@amd.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

+1 more reviewer

@SageMoore SageMoore SageMoore approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

rocm Related to AMD ROCm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@charlifu @SageMoore @DarkLight1337 @hongxiayang @vllm-bot