Move V1 into regular mypy call
#17044
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once all code inside
vllm/v1ismypycompliant, this PR should be mergeable.Relevant PRs that udpate typing in
vllm/v1:pidpassed tokill_process_treeisintformypy#17051@propertyand private field fordata_parallel_rank_local#17053LoRAModelRunnerMixin#17104get_text_config()instead of checking fortext_config#17105v1/attention#17113