Skip to content

Fix OOT registration test #17099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

Fix OOT registration test #17099

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
817c82b
Fix test
hmellor Apr 24, 2025
637bcf8
Resond to comment
hmellor Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions tests/models/test_oot_registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@ def test_plugin(
m.setenv("VLLM_USE_V1", "0")
m.setenv("VLLM_PLUGINS", "")

with pytest.raises(Exception) as excinfo:
match = "Cannot find model module"
with pytest.raises(ValueError, match=match):
LLM(model=dummy_opt_path, load_format="dummy")
error_msg = "has no vLLM implementation and the Transformers implementation is not compatible with vLLM" # noqa: E501
assert (error_msg in str(excinfo.value))


@create_new_process_for_each_test()
Expand Down