Skip to content

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Apr 24, 2025

Keeping the Transformers pin fresh to minimise the the effort required when updating from very old versions.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Apr 24, 2025
@DarkLight1337
Copy link
Member

DarkLight1337 commented Apr 24, 2025

Do you know when Qwen2.5-Omni will be released in transformers? I'm thinking of only bumping the version once that is out

@hmellor
Copy link
Member Author

hmellor commented Apr 24, 2025

Given how painful previous updates have been I was keen to keep up to date so that any required changes when bumping version are more manageable.

We have https://github.com/huggingface/transformers/releases/tag/v4.51.3-Qwen2.5-Omni-preview which users should be able to use now. As for the next minor release, we're expecting one in the next few weeks.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 24, 2025
@DarkLight1337
Copy link
Member

I have unblocked the tests to check whether we can safely upgrade the transformers version

@DarkLight1337 DarkLight1337 added this to the v0.8.5 milestone Apr 24, 2025
@DarkLight1337
Copy link
Member

DarkLight1337 commented Apr 25, 2025

We should use HF_EXAMPLE_MODELS in language model tests and skip ChatGLM for the current transformers version

hmellor added 3 commits April 25, 2025 12:13
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor requested a review from ywang96 as a code owner April 25, 2025 10:15
hmellor added 4 commits April 25, 2025 12:33
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@vllm-bot vllm-bot merged commit 0bd7f8f into vllm-project:main Apr 25, 2025
70 of 72 checks passed
@hmellor hmellor deleted the update-transformers branch April 25, 2025 15:46
@huydhn huydhn mentioned this pull request Apr 28, 2025
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants