Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Apr 25, 2025

Fix failing tests in test_hybrid.py. Also, consolidate the tests from test_mamba.py into this file to avoid duplicated code.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this - LGTM when green

Some comments on the test failures

  1. Looks like some tests aren't getting cleaned up properly

  2. This is a bug -- the ConstantSizeCache unfortunately needs to look at the attention metadata and is choking on xgrammar being there instead of flash attn

[2025-04-25T12:45:10Z] FAILED models/decoder_only/language/test_hybrid.py::test_multistep_correctness[64-float-ai21labs/Jamba-tiny-dev] - ValueError: Multi-Step not supported for attention backend: XFORMERS. Set VLLM_ATTENTION_BACKEND to a value from ['FLASH_ATTN', 'ROCM_FLASH', 'FLASHINFER', 'NO_ATTENTION'].
  1. I've found the hybrid and mamba tests to be pretty flakey... Somewhat suspect some numerical instability either in the models or the implementation but I don't have any hints as to what would be going wrong
[2025-04-25T12:45:10Z] FAILED models/decoder_only/language/test_hybrid.py::test_mamba_prefill_chunking[7-bfloat16-Zyphra/Zamba2-1.2B-instruct] - AssertionError: Test1:
--
  | [2025-04-25T12:45:10Z] chunked:	'Briefly describe the major milestones in the development of artificial intelligence from 1950 to 2020.\n\nC. Discuss the impact'
  | [2025-04-25T12:45:10Z] non_chunked:	'Briefly describe the major milestones in the development of artificial intelligence from 1950 to 2020.\n\nC. Discuss the ethical'

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 25, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 25, 2025 15:33
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@vllm-bot vllm-bot merged commit 43faa04 into vllm-project:main Apr 25, 2025
25 of 27 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-hybrid-tests branch April 26, 2025 09:27
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants