Skip to content

[Misc] Inline Molmo requirements #17190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2025
Merged

[Misc] Inline Molmo requirements #17190

merged 2 commits into from
Apr 25, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Apr 25, 2025 •
edited by github-actions bot
Loading

This avoids false-positive security flags due to having old libraries in requirements directory.

@DarkLight1337
[Misc] Inline Molmo requirements
247d3e3 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 requested a review from russellb April 25, 2025 14:18
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 mentioned this pull request Apr 25, 2025
Merged
@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Apr 25, 2025
russellb
russellb reviewed Apr 25, 2025
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't think it's appropriate to recommend vulnerable old versions.

I guess it'd be OK if it comes with a large warning.

@DarkLight1337
Add a note about security implications
c0df8a0 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Copy link
Member Author

Added a note. How about now?

@russellb russellb enabled auto-merge (squash) April 25, 2025 15:13
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 25, 2025
@russellb russellb mentioned this pull request Apr 25, 2025
Closed
@russellb russellb merged commit 9d98ab5 into vllm-project:main Apr 25, 2025
36 of 40 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-molmo-requirements branch April 25, 2025 22:03
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @dbyoung18
[Misc] Inline Molmo requirements (vllm-project#17190)
477a461 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @lk-chen
[Misc] Inline Molmo requirements (vllm-project#17190)
5fd651e 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@DarkLight1337 @adobrzyn
[Misc] Inline Molmo requirements (vllm-project#17190)
73936c7 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Misc] Inline Molmo requirements (vllm-project#17190)
f0d2a4f 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russellb russellb russellb approved these changes

Assignees

No one assigned

Labels

ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DarkLight1337 @russellb