Skip to content

[Bugfix] Fix standard models tests #17217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 26, 2025
Merged

[Bugfix] Fix standard models tests #17217

merged 5 commits into from
Apr 26, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Apr 26, 2025 •
edited
Loading

Fix OOM test_models.py by using specific models. Also remove older min_transformers_versions since they're unnecessary.

@DarkLight1337
[Bugfix[ Fix standard models tests
3b3827c 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 26, 2025
@DarkLight1337 DarkLight1337 requested a review from mgoin April 26, 2025 03:11
@DarkLight1337 DarkLight1337 requested a review from ywang96 as a code owner April 26, 2025 03:11
@github-actions
Copy link

github-actions bot commented Apr 26, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Update registry
5c388b7 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 requested a review from hmellor April 26, 2025 03:23
@DarkLight1337 DarkLight1337 changed the title [Bugfix[ Fix standard models tests [Bugfix] Fix standard models tests Apr 26, 2025
@DarkLight1337
Fix
2e41196 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 26, 2025
@DarkLight1337 DarkLight1337 requested a review from Isotr0py April 26, 2025 05:07
Isotr0py
Isotr0py approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Just a nit, PTAL!

@DarkLight1337
Address comments
90d194d 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@Isotr0py Isotr0py enabled auto-merge (squash) April 26, 2025 05:32
hmellor
hmellor approved these changes Apr 26, 2025
View reviewed changes
@DarkLight1337
Fix
9757326 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@vllm-bot vllm-bot merged commit 909fdaf into vllm-project:main Apr 26, 2025
9 of 14 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-model-tests branch April 26, 2025 09:26
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @dbyoung18
[Bugfix] Fix standard models tests (vllm-project#17217)
e982c44 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @lk-chen
[Bugfix] Fix standard models tests (vllm-project#17217)
cd20867 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@DarkLight1337 @adobrzyn
[Bugfix] Fix standard models tests (vllm-project#17217)
9f572e1 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Bugfix] Fix standard models tests (vllm-project#17217)
976232a 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@DarkLight1337
[Bugfix] Fix standard models tests (vllm-project#17217)
1e14502 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@hmellor hmellor hmellor approved these changes

@mgoin mgoin Awaiting requested review from mgoin

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DarkLight1337 @hmellor @Isotr0py @vllm-bot