[MISC] Use string annotation types for class definitions #17244
Conversation
Signed-off-by: Jade Zheng <zheng.shoujian@outlook.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
jianzs
changed the title
Signed-off-by: Jade Zheng <zheng.shoujian@outlook.com>
github-actions
bot
added
the
ready
|
|
||
| @classmethod | ||
| def check_and_update_config(cls, vllm_config: VllmConfig) -> None: | ||
| def check_and_update_config(cls, vllm_config: "VllmConfig") -> None: |
There was a problem hiding this comment.
You can make it with from __future__ import annotations, it will automatically convert all annotations to string.
There was a problem hiding this comment.
I think either way is fine.
…t#17244) Signed-off-by: Jade Zheng <zheng.shoujian@outlook.com>
…t#17244) Signed-off-by: Jade Zheng <zheng.shoujian@outlook.com>
…t#17244) Signed-off-by: Jade Zheng <zheng.shoujian@outlook.com> Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
…t#17244) Signed-off-by: Jade Zheng <zheng.shoujian@outlook.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
…t#17244) Signed-off-by: Jade Zheng <zheng.shoujian@outlook.com> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
3 participants
This change replamces explicit class definitions with string annotations for type hints, simplifying the import structure and avoiding circular dependencies. The modification maintains the original functionality while improving code readability and reducing potential import-related issues.