-
-
Notifications
You must be signed in to change notification settings - Fork 11k
Make name of compressed-tensors quant method consistent across vLLM
#17255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make name of compressed-tensors quant method consistent across vLLM
#17255
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
This was done for backcompat since some model configs use dash and others use underscore, so I would want to make sure both would still match |
|
Ok, I'll add some post processing to coerce any hyphens to underscores, then after that point we can standardise on Since we already call |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
The error in the fast check seems unrelated link: |
|
FWIW the standard is
|
compressed_tensors quant method consistent across vLLMcompressed-tensors quant method consistent across vLLM
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Since |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for getting this in a good state
…vllm-project#17255) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…vllm-project#17255) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…vllm-project#17255) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
…vllm-project#17255) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
The compressed tensors quantization method was referred to as
compressed-tensorsandcompressed_tensorsin different places, they've now been standardised tocompressed-tensors.Issue was discovered in #17130.
Splitting the fix into this PR to reduce the review load on the original.