Skip to content

Explicitly explain quant method override ordering and ensure all overrides are ordered #17256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 28, 2025
Merged

Explicitly explain quant method override ordering and ensure all overrides are ordered #17256

merged 4 commits into from
Apr 28, 2025

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Apr 27, 2025

Quantization method overrides are more clearly commented and enforced in config.py.

Issue was discovered in #17130.

Splitting the fix into this PR to reduce the review load on the original.

@hmellor
Explicitly explain quant method override ordering and ensure all over…
e7a753f 
…rides are ordered

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor mentioned this pull request Apr 27, 2025
Merged
DarkLight1337
DarkLight1337 reviewed Apr 27, 2025
View reviewed changes
DarkLight1337
DarkLight1337 reviewed Apr 27, 2025
View reviewed changes
hmellor added 3 commits April 27, 2025 16:05
@hmellor
Don't create QuantizationMethods because we don't need it in this PR
dc4c362 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Don't raise error for custom quant methods
4afe742 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Give custom overrides priority over build in ones
4b182c3 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Copy link
Member Author

hmellor commented Apr 27, 2025

cc @mgoin

@hmellor hmellor requested a review from DarkLight1337 April 28, 2025 11:49
mgoin
mgoin approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 28, 2025
@mgoin mgoin enabled auto-merge (squash) April 28, 2025 15:05
@mgoin mgoin merged commit c7941cc into vllm-project:main Apr 28, 2025
65 checks passed
@hmellor hmellor deleted the quant-override-clarity branch April 28, 2025 18:22
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@hmellor @dbyoung18
Explicitly explain quant method override ordering and ensure all over…
45dd547 
…rides are ordered (vllm-project#17256)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@hmellor @lk-chen
Explicitly explain quant method override ordering and ensure all over…
5826aab 
…rides are ordered (vllm-project#17256)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Explicitly explain quant method override ordering and ensure all over…
7ed97b8 
…rides are ordered (vllm-project#17256)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@hmellor
Explicitly explain quant method override ordering and ensure all over…
bda357b 
…rides are ordered (vllm-project#17256)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337

Assignees

No one assigned

Labels

quantization ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hmellor @mgoin @DarkLight1337