Skip to content

[Misc][ROCm] Exclude cutlass_mla_decode for ROCm build #17289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2025
Merged

[Misc][ROCm] Exclude cutlass_mla_decode for ROCm build #17289

merged 3 commits into from
Apr 29, 2025

Conversation

@tywuAMD
Copy link
Contributor

@tywuAMD tywuAMD commented Apr 28, 2025

A small fix for #16032. Do not include the op cutlass_mla_decode for ROCm build; otherwise it will cause some import error.

@tywuAMD
Exclude cutlass_mla_decode for ROCm build
f11044e 
Signed-off-by: Tianyuan Wu <Tianyuan.Wu@amd.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@tywuAMD tywuAMD changed the title [Minor][ROCm] Exclude cutlass_mla_decode for ROCm build [MISC][ROCm] Exclude cutlass_mla_decode for ROCm build Apr 28, 2025
@tywuAMD tywuAMD changed the title [MISC][ROCm] Exclude cutlass_mla_decode for ROCm build [Misc][ROCm] Exclude cutlass_mla_decode for ROCm build Apr 28, 2025
LucasWilkinson
LucasWilkinson approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, left one small nit. Thanks for the contribution!

tywuAMD added 2 commits April 29, 2025 02:41
@tywuAMD
Move cutlass_mla_decode down into existing macro
9540d27 
Signed-off-by: Tianyuan Wu <Tianyuan.Wu@amd.com>
@tywuAMD
Formatting
3c27d5b 
Signed-off-by: Tianyuan Wu <Tianyuan.Wu@amd.com>
@LucasWilkinson LucasWilkinson enabled auto-merge (squash) April 29, 2025 04:05
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 29, 2025
@nlzy nlzy mentioned this pull request Apr 29, 2025
Closed
@vllm-bot vllm-bot merged commit 06ffc7e into vllm-project:main Apr 29, 2025
87 of 89 checks passed
@LucasWilkinson LucasWilkinson mentioned this pull request Apr 29, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@tywuAMD @lk-chen
[Misc][ROCm] Exclude cutlass_mla_decode for ROCm build (vllm-projec…
5f7fcf1 
…t#17289)

Signed-off-by: Tianyuan Wu <Tianyuan.Wu@amd.com>
@Pl4tiNuM
Copy link

Pl4tiNuM commented May 2, 2025 •
edited
Loading

Is this issue also fixed when using VLLM_USE_PRECOMPILED=1 pip install --editable . for v0.8.5 or do we have to build everything from source?

radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
@tywuAMD @radeksm
[Misc][ROCm] Exclude cutlass_mla_decode for ROCm build (vllm-projec…
11b2465 
…t#17289)

Signed-off-by: Tianyuan Wu <Tianyuan.Wu@amd.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@tywuAMD
[Misc][ROCm] Exclude cutlass_mla_decode for ROCm build (vllm-projec…
ad60e14 
…t#17289)

Signed-off-by: Tianyuan Wu <Tianyuan.Wu@amd.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@tywuAMD
[Misc][ROCm] Exclude cutlass_mla_decode for ROCm build (vllm-projec…
83130f3 
…t#17289)

Signed-off-by: Tianyuan Wu <Tianyuan.Wu@amd.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Levi080513 pushed a commit to Levi080513/vllm that referenced this pull request Jul 8, 2025
@tywuAMD @Levi080513
[Misc][ROCm] Exclude cutlass_mla_decode for ROCm build (vllm-projec…
b73c23a 
…t#17289)

Signed-off-by: Tianyuan Wu <Tianyuan.Wu@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LucasWilkinson LucasWilkinson LucasWilkinson approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tywuAMD @Pl4tiNuM @LucasWilkinson @vllm-bot