Skip to content

Improve conversion from dataclass configs to argparse arguments #17303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 28, 2025
Merged

Improve conversion from dataclass configs to argparse arguments #17303

merged 4 commits into from
Apr 28, 2025

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Apr 28, 2025 •
edited by github-actions bot
Loading

  • optional_x has been replaced with optional_type(x) so we don't need different methods for different types
  • proper deprecation warning and timeline added for nullabke_kvs
  • tuple args can now have specific number of values if the config does not use Ellipsis
  • list args are also supported now
  • Optional configs are now handled much better as optional args:
    • The code is cleaner and more readable
    • "None" is added as a choice if the arg has choices

This was originally done in #17130, but has been split into this PR to reduce the review load on the original.

hmellor added 2 commits April 28, 2025 13:32
@hmellor
Use optional_type instead of type specific methods
b226eb3 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Refactor get_kwargs to handle optional better (+list support)
4d3fc49 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor mentioned this pull request Apr 28, 2025
Merged
@mergify mergify bot added the frontend label Apr 28, 2025
@hmellor hmellor changed the title Improve conversion from config dataclass to argparse arguments Improve conversion from dataclass configs to argparse arguments Apr 28, 2025
@hmellor
Make mypy happy
23465e5 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor mentioned this pull request Apr 28, 2025
Merged
@DarkLight1337
Copy link
Member

Can you add some tests to verify this?

@hmellor
Move helpers out of EngineArgs.add_cli_args and add tests
5123e01 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Copy link
Member Author

hmellor commented Apr 28, 2025

I've added tests for every helper function used to convert dataclass configs into argparse arguments

DarkLight1337
DarkLight1337 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM now!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 28, 2025 14:04
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 28, 2025
@DarkLight1337 DarkLight1337 merged commit f948869 into vllm-project:main Apr 28, 2025
51 of 53 checks passed
@hmellor hmellor deleted the update-get-kwargs branch April 28, 2025 16:22
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@hmellor @dbyoung18
Improve conversion from dataclass configs to argparse arguments (vllm…
bdb5b44 
…-project#17303)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@hmellor @lk-chen
Improve conversion from dataclass configs to argparse arguments (vllm…
db46b7b 
…-project#17303)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Improve conversion from dataclass configs to argparse arguments (vllm…
c96d33c 
…-project#17303)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@hmellor
Improve conversion from dataclass configs to argparse arguments (vllm…
3e8fa7c 
…-project#17303)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hmellor @DarkLight1337