Skip to content

ForwardContext does not offer a stable API #17308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ForwardContext does not offer a stable API #17308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions vllm/forward_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,20 @@ class ForwardContext:
# set dynamically for each forward pass
dp_metadata: Optional[DPMetadata] = None

def get_virtual_engine(self):
return self.virtual_engine
Comment on lines +48 to +49
Copy link
Member

@tlrmchlsmth tlrmchlsmth Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Author

@liranschour liranschour Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlrmchlsmth OK will use VllmConfig.get_layers_from_vllm_config() inside LMCache and close this PR.


def get_kv_cache_attn_layers(self) -> dict[str, Any]:
attn_layers = {}
for layer_name in self.no_compile_layers:
attn_layer = self.no_compile_layers[layer_name]
if not hasattr(attn_layer, "kv_cache"):
logger.debug("The layer %s does not have kv_cache, skip it",
layer_name)
continue
attn_layers[layer_name] = attn_layer

return attn_layers

_forward_context: Optional[ForwardContext] = None

Expand Down
Loading